Improve interface non-public method error message #7086
Conversation
|
I think "must be public" would be better. |
Currently interface methods with visibility `private` or `protected` fail with an error message: Access type for interface method A::b() must be omitted However, explicitly setting visibility `public` is allowed and often desired. This commit updates the error message to: Access type for interface method A::b() must be public
Ayesh
force-pushed
the
interface-visibility-error-msg
branch
from
6022a24 to
5340bac
Compare
|
Thank you @krakjoe - I just force-pushed with the updated error message. |
|
Thank you @Girgias. |
|
I am a bit late to the party, but I wanted to suggest to also deal with the "access type" part of the message. In my opinion, "Visibility of interface method..." would be more consistent with the terminology used in the documentation (https://www.php.net/manual/en/language.oop5.visibility.php) - although it also heavily uses "access", so neither "access type" is that bad after all, I guess. |
|
Actually, I was also working on improving error messages last year, and I got some inspiration from one of my old PRs: https://github.com/php/php-src/pull/6385/files#diff-7eccab80ba3e1beb270eb11da8c9642103ed12f3abb12e0acc71b8e344f0eac3R14: This is the version which sounds the most natural for me. |
Currently interface methods with visibility
privateorprotectedfail with an error message:However, explicitly setting visibility
publicis allowed and often desired. This commit updates the error message to: