Fix #53092 - dns_get_record does not return false on dns server failure #718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (h_errno == NO_DATA) { | ||
| continue; | ||
| } else { | ||
| php_error_docref(NULL TSRMLS_CC, E_WARNING, "Dns Query failed"); |
There was a problem hiding this comment.
Should be "DNS query failed".
There was a problem hiding this comment.
@lstrojny Hmm, yes. That means I should probably fix that in the Windows code as well :)
|
Original reporter here: if this works, then highly supported. Only 4 years! |
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to fix bug 53092 by making
dns_get_record()returnfalsewhen an error has occurred during the query.It's similar to its Windows counter part and adds a few useful warning messages when a request fails.