Fix bug #81325 Segfault in zif_simplexml_import_dom #7335
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remicollet
referenced
this pull request
Aug 3, 2021
|
Test? |
|
@nikic, I'm trring to extract from laminas-xmlrpc test suite... no success for now |
|
@nikic test added |
nikic
approved these changes
Aug 3, 2021
krakjoe
reviewed
Aug 3, 2021
| --SKIPIF-- | ||
| <?php | ||
| if (!extension_loaded('simplexml')) die('skip simplexml not available'); | ||
| if (!extension_loaded('dom')) die('skip simplexml not available'); |
There was a problem hiding this comment.
skip message is incorrect
can this use EXTENSIONS section ?
There was a problem hiding this comment.
EXTENSIONS is used as of 8.1 only.
There was a problem hiding this comment.
skip message is incorrect
@krakjoe, typo fixed.
can this use EXTENSIONS section ?
This is only 8.1, right ?
There was a problem hiding this comment.
ah right, missed target ... so in master it should use EXTENSIONS, and in 8.0 the skip message should change for dom ....
|
Merged as 112527d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce in 8.0.7RC1 by cb84e5c