snmp: add SHA256 and SHA512 for security protocol #7342
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morrisonlevi
reviewed
Aug 5, 2021
remicollet
force-pushed
the
issue-snmp-sha256
branch
from
16a232e to
dbabd78
Compare
nikic
reviewed
Aug 11, 2021
| smart_string_appendl(&err, " or \"MD5\"", 9); | ||
| #endif | ||
| smart_string_0(&err); | ||
| zend_value_error("%s", err.c); |
There was a problem hiding this comment.
I'd find it more elegant to use smart_str and then do zend_throw_exception_zstr(zend_ce_value_error, err.s, 0) here. No need to go through sprintf if we already have the full message :)
There was a problem hiding this comment.
Not using "%s" raise a security build warning
There was a problem hiding this comment.
[-Werror=format-security]
There was a problem hiding this comment.
Just to be clear, what I had in mind is using an API that uses zend_string (zend_throw_exception_zstr) and thus can just use the string directly. But your current version is okay as well.
nikic
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only add recommended protocol (not optional ones, don't think it really make sense to add them)