Skip to content

implementation for parse_query_string #7344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kamil-tekiela
Copy link
Member

@iluuu1994
Copy link
Member

@kamil-tekiela Not much has happened here, are you still planning on pursuing this RFC?

@kamil-tekiela
Copy link
Member Author

@kamil-tekiela Not much has happened here, are you still planning on pursuing this RFC?

Please leave it open for a few more weeks. I was meant to come back to it, but didn't get the time.

@kamil-tekiela
Copy link
Member Author

I have withdrawn this RFC. While I stand by my stopgap solution, I also feel like this won't solve the issues plaguing the current query parsing solution and thus offers negligible improvement. I can't easily fix the existing implementation without completely redesigning it or providing an alternative extension. Even if we only wanted to stop value mangling, it would be a BC break that cannot be implemented in PHP 8.2.

If someone wants to pick it up, feel free. For PHP 9.0 we might consider replacing it and removing data mangling.

@johanrosenson
Copy link

@kamil-tekiela

I'm late to the party, but I'm sad to see this RFC being withdrawn.

I was looking forward for it just for the much improved name and dropping of output variable, for me that was enough to warrant this RFC.

But easy enough to implement in userland also i suppose (which i have done in some projects now inspired by this RFC, thanks!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants