Improve the success rate when use mkdir() in multiprocessing environment #7383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Aug 18, 2021
main/streams/plain_wrapper.c
Outdated
| php_error_docref(NULL, E_WARNING, "%s", strerror(errno)); | ||
| } | ||
| if (ret < 0 && errno != EEXIST) { | ||
| /* stop running and issue a warning to client when ret < 0 and errno != EEXIST */ |
There was a problem hiding this comment.
Can you please keep the options & REPORT_ERRORS check here?
There was a problem hiding this comment.
And could you please switch the indentation from spaces -> tabs?
There was a problem hiding this comment.
Can you please keep the
options & REPORT_ERRORScheck here?
Fix it. Thanks foy your code review.
There was a problem hiding this comment.
And could you please switch the indentation from spaces -> tabs?
Fix it. Thanks foy your code review.
nikic
approved these changes
Aug 18, 2021
|
Let's add this to 7.x, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A process a want to create /home/test/a directory.
Another process b want to create /home/test/b directory.
But process b will fail rather than creating /home/test/b directory if /home/test/ directory had created by process a.
So I optimize php_plain_files_mkdir function to improve the success rate.
@nikic
I am so sorry.
I issued a new pr and closed old pr because of my unintentional operation.
I hope it won't cause any inconvenience.
Thanks.