Skip to content

Conversation

mbeccati
Copy link
Contributor

No description provided.

@mbeccati mbeccati changed the title Added nowait argument to sem_acquire Added optional nowait argument to sem_acquire Jul 25, 2014
@guilhermeblanco
Copy link

I'd propose instead of accepting "nowait" only, I'd use a better support and accept "until", dealing with possible cases:

  • -1: Blocks and wait until lock is acquired (default for BC compat)
  • 0: Exactly what your patch does, attempt to grab and if it fails, just return false (I'd remove the E_WARNING)
  • 0: Acceptable time in milliseconds it would wait until consider the acquire failed

@mbeccati
Copy link
Contributor Author

Committed to PHP-5.6 and master.

3571a68..0b648a4 PHP-5.6 -> PHP-5.6
5b82430..205b6b8 master -> master

@mbeccati mbeccati closed this Sep 10, 2014
@mbeccati mbeccati deleted the sem_acquire_nowait branch September 10, 2014 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants