Skip to content

Fix gdAlphaMax limit typo #7410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix gdAlphaMax limit typo #7410

wants to merge 1 commit into from

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Aug 26, 2021 •
edited
Loading

Fix #7402, gdAlphaMax is 127.

Also submitted merged to the gd lib as libgd/libgd#741.

@cmb69
Copy link
Member

cmb69 commented Aug 26, 2021

Thank you! I would like to wait on whether the other 255s will be replaced with the respective macros, to avoid changing this again, and doing the upward merges.

@krakjoe krakjoe added the Bug label Aug 31, 2021
@mvorisek
Copy link
Contributor Author

Let's land this as a pure fix for 526407c

cmb69
cmb69 approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Completely forgot about this.

@cmb69 cmb69 closed this in 2c3dfe5 Sep 23, 2021
@mvorisek mvorisek deleted the patch-1 branch September 23, 2021 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvorisek @cmb69 @krakjoe