Don't expose wchar encoding to users #7415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "wchar" encoding isn't really an encoding -- it's what we internally use as the representation of decoded characters. In practice, it tends to behave a lot like the 8bit encoding when used from userland, because input code units end up being treated as code points. This patch removes the wchar encoding from the public encoding list and reserves it for internal use only.
|
Based on the fact that this doesn't cause a single test failure, and there are no relevant usages of Only found reference is https://github.com/gggeek/phpxmlrpc/blob/b337d292eb5b5656d27a2fc9ab6796be300c59a3/src/Client.php#L205, which is about explicitly removing |
|
The manual doesn't even mention the |
|
+1 from me. Do we even need this internally? |
Currently, it is definitely needed internally. After some more refactoring... it may not be. |
|
This is a good step. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "wchar" encoding isn't really an encoding -- it's what we
internally use as the representation of decoded characters.
In practice, it tends to behave a lot like the 8bit encoding when
used from userland, because input code units end up being treated
as code points.
This patch removes the wchar encoding from the public encoding
list and reserves it for internal use only.