Restore old PDO::PARAM_* values #7445
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an ABI-breaking change. Landing it would require the PHP 8.1 RC1 release to be retagged. Leaving it up to RMs whether we want to do that or not... |
As it is not officially announced, I am ok retagging it. |
|
Why was it changed in the first place? |
I don't think it was intentional (caa7100). |
Doctrine hardcodes the values of these constants, avoid changing them. Fixes https://bugs.php.net/bug.php?id=81405.
nikic
force-pushed
the
pdo-param-values
branch
from
819ca59 to
f01a979
Compare
patrickallaert
approved these changes
Sep 1, 2021
|
@patrickallaert yes, do re-tagging ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doctrine hardcodes the values of these constants, avoid changing
them.
Fixes https://bugs.php.net/bug.php?id=81405.