Fix #81424: PCRE2 10.35 JIT performance regression #7484
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We backport the respective upstream fix[1] to our bundled pcre2lib. [1] <PCRE2Project/pcre2@dc5f966>
|
PHP has upgraded PCRE2 in patch releases before. An option is to upgrade to PCRE2 10.37 plus this patch across all of the 7.4, 8.0 and 8.1 series, and then also upgrade them all to 10.38 once that's released, assuming that happens before PHP 7.4 goes out of bug fix support? |
nikic
approved these changes
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We backport the respective upstream fix[1] to our bundled pcre2lib.
[1] PCRE2Project/pcre2@dc5f966
Background: we updated from PCRE2 10.34 to PCRE2 10.35 (which introduced this performance regression in PHP 7.4.12; this is why it might be reasonable to backport the fix to PHP-7.4. If we don't want to touch the stable branches, we should at least backport to PHP-8.1, which has PCRE2 10.37; or we see if we can update to PCRE2 10.38, which is not yet released, though.