Return old scale value from bcscale() #778
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for #67855
|
looks fine, just please add UPGRADING note |
|
Also now needs a rebase. |
|
@smalyshev No problem, I've not had a lot of time to deal with OSS work in the last couple of months, but I will try and close some of my outstanding work off in the next week or two. Apologies for this, I realise I'm doing something I complain about a lot myself by not following this through :-/ |
|
Although this says it is targeting master, it is so old that master has moved, and on closer inspection this actually is targeting PHP 5, since a patch against a supported branch would look different, I'm closing this PR. Please take this action as encouragement to open a PR against a supported branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #67855.
Make argument for
bcscale()optional, only update scale when the argument is passed, and always return the old value.As this is a (minor) backwards compatibility break, this patch targets master.