Bug 66777 #789
Closed
Bug 66777 #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this is a good idea as it is a ddos like restriction. Also, why would this string into strftime ever be so large? |
|
@derickr Why doesn't the buffer start with |
|
@datibbaw I don't know that, but just getting rid of the bounds is not the fix. |
|
Since this has merge conflicts, has been in effect rejected by the timelib maintainer (with whom I concur), and since the author seems to have abandoned working on it anyway, I'm closing this PR. Please take this as encouragement to pursue a superior solution, and open a clean PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.php.net/bug.php?id=66777
Remove upper bound for reallocations