Fixed FR #67915 - Improve strrchr()

[datibbaw]

This addresses FR 67915.

• Added optional third argument to strrchr() to select the part before the match
• Updated error test cases
• Added test cases for new behaviour

[ralt]

Sounds like the failed travis build is unrelated. I've seen it fail on the same tests in other unrelated cases, though it's fixed now, so it should be rerun.

[datibbaw]

Yes, they're unrelated. I've just created a PR to see if anyone would show up and say it shouldn't be done :)

We could probably add it to 5.6 as well actually.

On 5 Sep, 2014, at 4:41 am, Florian Margaine notifications@github.com wrote:

Sounds like the failed travis build is unrelated. I've seen it fail on the same tests in other unrelated cases, though it's fixed now, so it should be rerun.

—
Reply to this email directly or view it on GitHub.

[krakjoe]

Since this targets a PHP 5 branch, and since it has merge conflicts, and since a patch for a supported branch would have to be different, I'm closing this PR.

Please take this action as encouragement to open a clean PR against a supported branch.