Strip MariaDB 10 prefix #7970
Closed
Strip MariaDB 10 prefix #7970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmb69
approved these changes
Jan 19, 2022
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have reconsidered. While I am still uneasy about PHP stripping this value, it seems that MariaDB does recommend that.
Based on the linked conversation in #7963 and the earlier PR by Georg Richter from MariaDB I decided that it's ok to strip the prefix.
This PR removes the earlier implementation of this hack and also supersedes #7963. A unit test was added in mysqli but not in PDO. The test should succeed in PHP CI jobs no matter what as I don't think we have a CI job connecting to MariaDB. I tested this PR on Windows with MariaDB 10 and the test passed.
The PR is against PHP 8.0, but if we are worried about BC we can merge it only in Master.