Fixes #67960 - Long/short day names reversed in jddayofweek() #806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comment on behalf of tyrael at php.net: merged to 5.5 and upwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://bugs.php.net/bug.php?id=67960
We reverse the definitions of the constants, so that
CAL_DOW_LONGis now1andCAL_DOW_SHORTis now2so that they correspond with the definitions given in the documentation at http://www.php.net/function.jddayofweekThis means we need to reverse their usage in the code. Note here that previously,
CAL_DOW_LONGselected the short namesdaynamesandCAL_DOW_SHORTselected the long namesdaynamel!The test script is now driven from the constants - and since we test their numeric values in the expected output, we are checking that they are set consistently.