Remove alternative php tags #813
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
force-pushed
the
removeAlternativePhpTags
branch
from
b72de3c to
d9b766c
Compare
|
Shouldn't we deprecate short tags also? |
|
@guilhermeblanco short tags are useful for templating |
|
@JulienTant: Short echo open tag ( |
| @@ -2,7 +2,6 @@ | |||
| short_open_tag: Off, asp_tags: Off | |||
There was a problem hiding this comment.
Shouldn't this asp_tags mention be removed?
There was a problem hiding this comment.
Thanks, I dropped the mention :)
Removes: * <% opening tag * %> closing tag * <%= short opening tag * /<script\s+language\s*=\s*(php|"php"|'php')\s*>/i opening tag * /</script>/i closing tag * asp_tags ini directive
nikic
force-pushed
the
removeAlternativePhpTags
branch
from
d9b766c to
cc5925b
Compare
|
@Majkl578, why standard short open tag is trash? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes:
<%opening tag<%=short opening tag%>closing tag/<script\s+language\s*=\s*(php|"php"|'php')\s*>/iopening tag</script>closing tagasp_tagsini directive