New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove various deprecated functionality #815

Closed
wants to merge 12 commits into
base: master
from

Conversation

5 participants
@nikic
Member

nikic commented Sep 10, 2014

No description provided.

@nikic nikic changed the title from Remove varioud deprecated functionality to Remove various deprecated functionality Sep 10, 2014

@guilhermeblanco

This comment has been minimized.

Show comment
Hide comment
@guilhermeblanco

guilhermeblanco Sep 11, 2014

👍 once ready!

guilhermeblanco commented Sep 11, 2014

👍 once ready!

@Shine-neko

This comment has been minimized.

Show comment
Hide comment
@Shine-neko

Shine-neko commented Sep 15, 2014

👍

@hikari-no-yume

This comment has been minimized.

Show comment
Hide comment
@hikari-no-yume

hikari-no-yume Oct 12, 2014

Contributor

Does the removal of unsafe cURL uploads remove the CURLOPT_SAFE_UPLOAD option? Because if it does, it shouldn't. That should be kept around for 5.x/7.x compatibility. Obviously, it needs to error if set to false, but if set to true, it should just do nothing.

Contributor

hikari-no-yume commented Oct 12, 2014

Does the removal of unsafe cURL uploads remove the CURLOPT_SAFE_UPLOAD option? Because if it does, it shouldn't. That should be kept around for 5.x/7.x compatibility. Obviously, it needs to error if set to false, but if set to true, it should just do nothing.

@nikic

This comment has been minimized.

Show comment
Hide comment
@nikic

nikic Oct 12, 2014

Member

@TazeTSchnitzel Agree, it should be modified to keep the option itself around.

Member

nikic commented Oct 12, 2014

@TazeTSchnitzel Agree, it should be modified to keep the option itself around.

@smalyshev smalyshev added the RFC label Nov 18, 2014

@nikic

This comment has been minimized.

Show comment
Hide comment
@nikic

nikic Mar 9, 2015

Member

Closing as everything from this PR has been merged - apart from the incompatible context change which requires a different implementation.

Member

nikic commented Mar 9, 2015

Closing as everything from this PR has been merged - apart from the incompatible context change which requires a different implementation.

@nikic nikic closed this Mar 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment