Skip to content

Fix GH-8068: mysqli_fetch_object creates inaccessible properties #8189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix GH-8068: mysqli_fetch_object creates inaccessible properties #8189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
180b25e
Fix GH-8068: mysqli_fetch_object creates inaccessible properties
cmb69 Mar 10, 2022
ceb21df
Update ext/mysqli/tests/gh8068.phpt
cmb69 Mar 11, 2022
9b56569
Update ext/mysqli/tests/gh8068.phpt
cmb69 Mar 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ext/mysqli/mysqli.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1198,11 +1198,13 @@ void php_mysqli_fetch_into_hash(INTERNAL_FUNCTION_PARAMETERS, int override_flags
ZVAL_COPY_VALUE(&dataset, return_value);

object_init_ex(return_value, ce);
HashTable *prop_table = zend_symtable_to_proptable(Z_ARR(dataset));
zval_ptr_dtor(&dataset);
if (!ce->default_properties_count && !ce->__set) {
Z_OBJ_P(return_value)->properties = Z_ARR(dataset);
Z_OBJ_P(return_value)->properties = prop_table;
} else {
zend_merge_properties(return_value, Z_ARRVAL(dataset));
zval_ptr_dtor(&dataset);
zend_merge_properties(return_value, prop_table);
zend_array_release(prop_table);
}

if (ce->constructor) {
Expand Down
25 changes: 25 additions & 0 deletions ext/mysqli/tests/gh8068.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
--TEST--
GH-8068 (mysqli_fetch_object creates inaccessible properties)
--SKIPIF--
<?php
require_once 'skipif.inc';
require_once 'skipifconnectfailure.inc';
?>
--FILE--
<?php
require_once "connect.inc";
mysqli_report(MYSQLI_REPORT_ERROR | MYSQLI_REPORT_STRICT);
$mysqli = my_mysqli_connect($host, $user, $passwd, $db, $port, $socket);
$res = $mysqli->query('SELECT 42');
$obj = $res->fetch_object();
var_dump(
$obj,
$obj->{42}
);
?>
--EXPECT--
object(stdClass)#4 (1) {
["42"]=>
string(2) "42"
}
string(2) "42"