DateTimeZone::getOffset() now accepts a DateTimeInterface #831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| function handler($errno, $errstr) { | ||
| if ($errno === E_RECOVERABLE_ERROR) | ||
| echo $errstr . "\n"; |
There was a problem hiding this comment.
please use { } around conditional statements (in all files)
There was a problem hiding this comment.
I also don't quite understand why this is necessary?
There was a problem hiding this comment.
If I don't do this, PHP will throw a catchable fatal error at the first argument of the wrong type, so the test won't be able to run all the checks
|
@derickr I've fixed your styling comment, fixed a test (it used a local path), and squashed all the commits into a single clean one. As discussed in the internals mailing list, I'll write a fix in the PHP-5.6 branch, using ZEND_ARG_INFO to avoid breaking BC. I'll ping you in the new PR that'll come. |
Fixes #68062 Should be backported to PHP-5.6 and PHP-5.5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.php.net/bug.php?id=68062
This is a BC break, since the arguments are now declared using OBJ_ARG_INFO instead of plain ARG_INFO.
Should it be backported to 5.*, it would have to be kept with ARG_INFO.