Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BEGIN_EXTERN_C() and END_EXTERN_C() to .h files missing them. #840

Merged
merged 3 commits into from Nov 24, 2014

Conversation

5 participants
@LawnGnome
Copy link
Contributor

commented Sep 24, 2014

Bug: https://bugs.php.net/bug.php?id=68091

This can be applied directly to PHP-5.5 and merged upwards.

@bwoebi

This comment has been minimized.

Copy link
Contributor

commented Sep 28, 2014

zend_vm_opcodes.h is a generated file, could you please update the zend_vm_gen.php script too?

@hikari-no-yume

This comment has been minimized.

Copy link
Contributor

commented Oct 31, 2014

Do all Zend headers need this, or only ones we know will be used in C++ code?

@LawnGnome

This comment has been minimized.

Copy link
Contributor Author

commented Oct 31, 2014

@TazeTSchnitzel All, but most of them already do. This handles the three headers that did not.

@LawnGnome LawnGnome force-pushed the LawnGnome:zend-c++-compat branch from 25fc9d3 to 4bb836b Oct 31, 2014

@LawnGnome

This comment has been minimized.

Copy link
Contributor Author

commented Oct 31, 2014

@bwoebi Done. Sorry; I missed the notification when you posted last month.

@smalyshev smalyshev added the Quickfix label Nov 24, 2014

@php-pulls php-pulls merged commit 4bb836b into php:PHP-5.5 Nov 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.