Skip to content

Fix PDO MySQL URI test #8451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix PDO MySQL URI test #8451

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6afdf8
Fix PDO URI test
mvorisek Apr 28, 2022
d708bf7
keep testing chr(0) in DSN
mvorisek Apr 28, 2022
feed0db
reuse 1st test to test chr(0) behaviour as much as possible
mvorisek May 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 6 additions & 16 deletions ext/pdo_mysql/tests/pdo_mysql___construct_uri.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,9 @@ MySQLPDOTest::skip();
$dsn = MySQLPDOTest::getDSN();
$user = PDO_MYSQL_TEST_USER;
$pass = PDO_MYSQL_TEST_PASS;
$uri = sprintf('uri:file://%s', (substr(PHP_OS, 0, 3) == 'WIN' ? str_replace('\\', '/', $file) : $file));
$uri = 'uri:file://' . $file;

if ($fp = @fopen($file, 'w')) {
// ok, great we can create a file with a DSN in it
fwrite($fp, $dsn);
fclose($fp);
clearstatcache();
Expand All @@ -38,31 +37,23 @@ MySQLPDOTest::skip();
}

if ($fp = @fopen($file, 'w')) {
fwrite($fp, sprintf('mysql:dbname=letshopeinvalid;%s%s',
chr(0), $dsn));
fwrite($fp, $dsn . chr(0) . ';host=nonsense;unix_socket=nonsense');
fclose($fp);
clearstatcache();
assert(file_exists($file));
try {
$db = new PDO($uri, $user, $pass);
} catch (PDOException $e) {
$expected = array(
"SQLSTATE[HY000] [1049] Unknown database 'letshopeinvalid'",
"SQLSTATE[42000] [1049] Unknown database 'letshopeinvalid'",
"SQLSTATE[HY000] [2002] No such file or directory"
);
printf("[003] URI=%s, DSN=%s, File=%s (%d bytes, '%s'), chr(0) test, %s\n",
$uri, $dsn,
$file, filesize($file), file_get_contents($file),
(in_array($e->getMessage(), $expected) ? 'EXPECTED ERROR' : $e->getMessage()));
printf("[003] URI=%s, DSN=%s, File=%s (%d bytes, '%s'), %s\n",
$uri, $dsn,
$file, filesize($file), file_get_contents($file),
$e->getMessage());
}
unlink($file);
}

}

/* TODO: safe mode */

} catch (PDOException $e) {
printf("[001] %s, [%s] %s\n",
$e->getMessage(),
Expand All @@ -73,5 +64,4 @@ MySQLPDOTest::skip();
print "done!";
?>
--EXPECTF--
[003] URI=uri:file://%spdomuri.tst, DSN=mysql%sdbname=%s, File=%spdomuri.tst (%d bytes, 'mysql%sdbname=letshopeinvalid%s'), chr(0) test, EXPECTED ERROR
done!