Fixed bug #74671 (DST timezone abbreviation has incorrect offset) #8595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ext/intl/tests/dateformat_format_variant3.phpt uses "PDT", and that causes a test failure now. It's probably a good idea to replace that with a proper timezone. |
|
The test result was probably wrong before. |
derickr
force-pushed
the
bug74671-dst-c-format
branch
from
662dfe9 to
63a31f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The real fix should happen in timelib, but as we can't merge that into 8.0 due to behavioural changes, I'm also making this PR, besides fixing it properly in timelib (with derickr/timelib#127).