Skip to content

Fix undefined behavior in php_set_inet6_addr #8607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix undefined behavior in php_set_inet6_addr #8607

wants to merge 1 commit into from

Conversation

iluuu1994
Copy link
Member

Postfix ++ on NULL is undefined behavior

Found with Clangs UndefinedBehaviorSanitizer.

Should this target PHP 7.4? Do we consider all UB a security issue?

@iluuu1994
Fix undefined behavior in php_set_inet6_addr
ccdde15 
Postfix `++` on `NULL` is undefined behavior
nikic
nikic approved these changes May 22, 2022
View reviewed changes
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this target PHP 7.4? Do we consider all UB a security issue?

No.

@iluuu1994 iluuu1994 closed this in f0480eb May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iluuu1994 @nikic