Various fixes to allow support for new VS2014 features #869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dragonmantank
commented
Oct 6, 2014
dragonmantank
commented
- Added some typeof checks to handle JS errors introduced in Windows 10
- Added VS2014 to the list of compilers
- Changed to use stdint.h if we are using VS2014 or higher
- Skip defining timespec if we're using VS2014 or higher
- Moved u_char typedef out to always be defined regardless of VS version
dragonmantank
force-pushed
the
vs2014-fixes
branch
from
d0bb3b1 to
d987ce2
Compare
|
can you rebase/do a new commit to see if you can get a cleaner travis run on this? |
| #define snprintf _snprintf | ||
| #endif |
There was a problem hiding this comment.
This seems to be not correct, the '>' should be reversed. VS including 2013 has no full support for C99.
There was a problem hiding this comment.
Upon further inspection I messed up the check anyway, so this will be fixed with the next push.
- Added some typeof checks to handle JS errors introduced in VS2014 - Added VS2014 to the list of compilers - Changed to use stdint.h if we are using VS2014 or higher - Skip defining timespec if we're using VS2014 or higher - Moved u_char typedef out to always be defined regardless of VS version
dragonmantank
force-pushed
the
vs2014-fixes
branch
from
d987ce2 to
6b0eca0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.