Use get_active_function_or_method_name() for zend_forbid_dynamic_call() #8762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
reviewed
Jun 13, 2022
twose
force-pushed
the
zend_forbid_dynamic_call
branch
from
d258aad to
9808b2a
Compare
A slight imperfection in php#7443. As a zend_API, we should also consider other extensions that may call it in methods. This change will not break the behavior of php-src.
twose
force-pushed
the
zend_forbid_dynamic_call
branch
from
9808b2a to
20c88bd
Compare
kocsismate
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A slight imperfection in #7443.
As a zend_API, we should also consider other extensions that may call it in methods. This change will not break the behavior of php-src.