Skip to content

Replace the use of ZVAL_BOOL() with ZVAL_TRUE() or ZVAL_FALSE() where the value is fixed #8815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2022
Merged

Replace the use of ZVAL_BOOL() with ZVAL_TRUE() or ZVAL_FALSE() where the value is fixed #8815

merged 2 commits into from
Jun 20, 2022

Conversation

Yurunsoft
Copy link
Contributor

No description provided.

cmb69
cmb69 reviewed Jun 17, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks good to me, but I want to wait on Máté checking the change to gen_stub.php.

@Girgias Girgias requested a review from kocsismate June 18, 2022 11:42
@Girgias Girgias merged commit 5cf2659 into php:master Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 left review comments

@kocsismate kocsismate kocsismate approved these changes

Assignees
No one assigned
Labels
Category: Build System Extension: dba Extension: dom Extension: oci8 Extension: soap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Yurunsoft @cmb69 @kocsismate @Girgias