Skip to content

crc32 Aarch64 add crc feature to crc32_aarch64 from clang #8916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

crc32 Aarch64 add crc feature to crc32_aarch64 from clang #8916

wants to merge 1 commit into from

Conversation

devnexen
Copy link
Member

@devnexen devnexen commented Jul 4, 2022

No description provided.

@devnexen devnexen requested a review from Girgias July 12, 2022 17:21
Girgias
Girgias reviewed Jul 22, 2022
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, although far from a pragma expert. The fact that clang also considers itself GNUC is again being a PITA

@devnexen
Copy link
Member Author

Yes same reasoning for musl pretending to be glibc, "convenience" but that would be too complicated, most of the time, to do differently to be fair.

@devnexen devnexen closed this in 77bd39a Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias left review comments

Assignees
No one assigned
Labels
Extension: standard Waiting on Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devnexen @Girgias