Skip to content

QA - pcntl_signal - error when handler is int and not SIG_DFL or SIG_IGN #9001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 14, 2022
Merged

QA - pcntl_signal - error when handler is int and not SIG_DFL or SIG_IGN #9001

merged 3 commits into from
Jul 14, 2022

Conversation

juan-morales
Copy link
Contributor

Extension: pcntl
Function: pcntl_signal

When an int handler is passed that is different than SIG_DFL or SIG_IGN then error is expected.

Code coverage looks like:

Before
image

After
image

cmb69
cmb69 reviewed Jul 13, 2022
View reviewed changes
@cmb69 cmb69 merged commit 7b301e3 into php:master Jul 14, 2022
@cmb69
Copy link
Member

cmb69 commented Jul 14, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 left review comments

Assignees
No one assigned
Labels
Extension: pcntl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juan-morales @cmb69