Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes memory leak introduced in 2b9af967 #914

Merged
merged 1 commit into from
Dec 1, 2014
Merged

Fixes memory leak introduced in 2b9af967 #914

merged 1 commit into from
Dec 1, 2014

Conversation

ralt
Copy link
Contributor

@ralt ralt commented Nov 23, 2014

@ralt
Copy link
Contributor Author

ralt commented Nov 23, 2014

@derickr since you wrote the original code and you're ext/date maintainer, I think you're the best one to review this PR :-)

@derickr
Copy link
Member

derickr commented Nov 23, 2014

LGTM, but:

  • please run all ext/date tests with valgrind before merging this.

@smalyshev smalyshev added the Bug label Nov 23, 2014
@smalyshev
Copy link
Contributor

tried ext/date with valgrind, no memory errors.

@ralt
Copy link
Contributor Author

ralt commented Nov 26, 2014

All passed with ./run-tests.php -m ext/date/tests

@php-pulls php-pulls merged commit 489bfb0 into php:PHP-5.5 Dec 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ralt @derickr @smalyshev @php-pulls