Skip to content

Declare ext/gd constants in stubs #9180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2022
Merged

Declare ext/gd constants in stubs #9180

merged 2 commits into from
Jul 30, 2022

Conversation

kocsismate
Copy link
Member

No description provided.

@kocsismate kocsismate requested a review from cmb69 July 28, 2022 13:41
cmb69
cmb69 reviewed Jul 28, 2022
View reviewed changes
cmb69
cmb69 approved these changes Jul 30, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

(There are too many constants in PHP)

@cmb69
Copy link
Member

cmb69 commented Jul 30, 2022

The CI failures are unrelated to this PR.

@kocsismate kocsismate merged commit 056e968 into php:master Jul 30, 2022
@kocsismate kocsismate deleted the const-gd branch July 30, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
Extension: gd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kocsismate @cmb69