Skip to content

PcgOneseq128XslRr64::jump(): Throw ValueError for negative $advance #9213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 1, 2022
Merged

PcgOneseq128XslRr64::jump(): Throw ValueError for negative $advance #9213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d65107
PCG64: $advance must be non-negative
arokettu Jul 31, 2022
5887776
Missing return_throws
arokettu Aug 1, 2022
9ac119a
Add test for PcgOneseq128XslRr64::jump()
arokettu Aug 1, 2022
8db8ec6
Add closing tag to the test
arokettu Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ext/random/engine_pcgoneseq128xslrr64.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,11 @@ PHP_METHOD(Random_Engine_PcgOneseq128XslRr64, jump)
Z_PARAM_LONG(advance);
ZEND_PARSE_PARAMETERS_END();

if (UNEXPECTED(advance < 0)) {
zend_argument_value_error(1, "must be greater than or equal to 0");
RETURN_THROWS();
}

php_random_pcgoneseq128xslrr64_advance(state, advance);
}
/* }}} */
23 changes: 23 additions & 0 deletions ext/random/tests/02_engine/pcgoneseq128xslrr64_jump_error.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
--TEST--
Random: Engine: PcgOneseq128XslRr64: Jump with negative $advance
--FILE--
<?php

$engine = new \Random\Engine\PcgOneseq128XslRr64(1234);
$referenceEngine = new \Random\Engine\PcgOneseq128XslRr64(1234);

try {
$engine->jump(-1);
} catch (ValueError $e) {
echo $e->getMessage(), PHP_EOL;
}

if ($engine->generate() !== $referenceEngine->generate()) {
die('failure: state changed');
}

die('success');
?>
--EXPECT--
Random\Engine\PcgOneseq128XslRr64::jump(): Argument #1 ($advance) must be greater than or equal to 0
success