[PHP7] Zend language parser class decoupling #928
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
nice~ |
|
@smalyshev / @dstogov care to review and merge? @laruence already said it's good. =) |
|
@guilhermeblanco it's good, but it still needs a RFC :) (Sure I will vote + 1) |
|
@laruence then I'll die writing RFCs... I have 5 pending already! =( |
|
or, at least a mail to internals? |
|
Needs a NEWS and UPGRADING.INTERNALS commit as that could break extensions. |
guilhermeblanco
force-pushed
the
bison-class-decoupling
branch
from
fa38897 to
6bc92bd
Compare
|
@jpauli I updated the PR with changes for final constant change as per your request. Thanks. |
added 3 commits
December 6, 2014 04:50
…me currently defined classes as final which were just not being considered as such before.
guilhermeblanco
force-pushed
the
bison-class-decoupling
branch
from
6bc92bd to
cf249f4
Compare
|
Merged as part of #937 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consumes the PR #911
This makes easier to expand support around classes.
It also helps Bison with less checks. Also provides nicer fatal error around multiple final, multiple abstract, mix between abstract and final instead of generic parse error.