Skip to content

ext/session refactoring: INI settings #9322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

ext/session refactoring: INI settings #9322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8fdba23
Convert some Session globals from char* to zend_string*
Girgias Aug 12, 2022
4db9596
Convert session_name from char to zend_string
Girgias Aug 12, 2022
c91f1b8
Use NUL spelling
Girgias Aug 19, 2022
4cd856d
address review comments
Girgias Aug 19, 2022
91ec6fe
Check for session name criterias consistently
Girgias Aug 19, 2022
c8f0235
Use new API for checking if string has NUL bytes
Girgias Aug 22, 2022
f9e3e29
Use known length
Girgias Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ext/session/php_session.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,16 +141,16 @@ typedef struct _php_session_rfc1867_progress {

typedef struct _php_ps_globals {
char *save_path;
char *session_name;
zend_string *session_name;
zend_string *id;
char *extern_referer_chk;
char *cache_limiter;
zend_string *extern_referer_chk;
zend_string *cache_limiter;
zend_long cookie_lifetime;
char *cookie_path;
char *cookie_domain;
zend_string *cookie_path;
zend_string *cookie_domain;
bool cookie_secure;
bool cookie_httponly;
char *cookie_samesite;
zend_string *cookie_samesite;
const ps_module *mod;
const ps_module *default_mod;
void *mod_data;
Expand Down
Loading