Skip to content

Fix bug #68532: convert.base64-encode omits padding bytes #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix bug #68532: convert.base64-encode omits padding bytes #936

wants to merge 1 commit into from

Conversation

mcq8
Copy link
Contributor

@mcq8 mcq8 commented Dec 4, 2014

The memory stream will now read as much as possible and only set the EOF when you try to read when there is nothing left.
This is the way file streams do it and apparently some filter algorithms as convert.base64-encode depend on it.

@mcq8
Copy link
Contributor Author

mcq8 commented Dec 5, 2014

Can someone with write access rerun travis CI?
It is just a random failure because a socket port was in use during the tests.

@smalyshev smalyshev added the Bug label Dec 6, 2014
@jpauli
Copy link
Member

jpauli commented Dec 12, 2014

This has been merged against 5.5 and up

@jails
Copy link
Contributor

jails commented Feb 7, 2015

Before this bugfix, feof() returned true one byte earlier as it should. However this bugfix introduced a glitch since EOF should be marked as true when the read call is done with a length > stream length right away. With this bugfix, read() needs to be called twice: https://bugs.php.net/bug.php?id=68948.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants