Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix class name FQN when AST dumping new and class const #9462

Conversation

iluuu1994
Copy link
Member

Fixes GH-9447

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue also affects PHP 8.0 as pointed out in the issue so this should target that version IMHO

Zend/zend_compile.h Show resolved Hide resolved
@iluuu1994
Copy link
Member Author

This issue also affects PHP 8.0 as pointed out in the issue so this should target that version IMHO

@Girgias It's not though. new in const expressions wasn't available in 8.0, and class constants were resolved before they were dumped. https://3v4l.org/LI6OG

@Girgias
Copy link
Member

Girgias commented Sep 1, 2022

This issue also affects PHP 8.0 as pointed out in the issue so this should target that version IMHO

@Girgias It's not though. new in const expressions wasn't available in 8.0, and class constants were resolved before they were dumped. https://3v4l.org/LI6OG

I can't read as usual somehow

@iluuu1994
Copy link
Member Author

iluuu1994 commented Sep 1, 2022

One unfortunate thing is that the code still checks for the ZEND_NAME_ flags using ==. However, in this particular case these flags should never be set (as the name should always be fully qualified), so it's probably not worth updating.

@iluuu1994 iluuu1994 closed this in 2cfb028 Sep 2, 2022
@nicolas-grekas
Copy link
Contributor

Awesome thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants