Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PDEATHSIG to kill cli-server workers if parent exits #9476

Closed
wants to merge 3 commits into from
Closed

Use PDEATHSIG to kill cli-server workers if parent exits #9476

wants to merge 3 commits into from
+114 −32

Conversation

iluuu1994
Copy link
Member

No description provided.

@iluuu1994 iluuu1994 changed the title Use PDEATHSIG to kill cli-server workers if parent exists Use PDEATHSIG to kill cli-server workers if parent exits Sep 2, 2022
devnexen
devnexen reviewed Sep 2, 2022
View reviewed changes
sapi/cli/php_cli_server.c Outdated Show resolved Hide resolved
@iluuu1994
Copy link
Member Author

Oh, it doesn't look like FreeBSDs ps has a ppid filter 🙁
https://www.freebsd.org/cgi/man.cgi?ps(1)

I'll see if I can switch to pgrep.

@iluuu1994
Copy link
Member Author

I'll see if I can switch to pgrep.

Yay, that worked 🙂

@iluuu1994 iluuu1994 closed this in ecc3fc1 Sep 8, 2022
iluuu1994 added a commit that referenced this pull request Sep 8, 2022
@iluuu1994
[skip ci] Add missing NEWS entry for GH-9476
ec6893e
@iluuu1994 iluuu1994 deleted the cli-server-pdeathsig branch March 21, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 left review comments

@devnexen devnexen devnexen left review comments

Assignees
No one assigned
Labels
Category: Build System Category: Engine SAPI: cli SAPI: fpm SAPI: litespeed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iluuu1994 @cmb69 @devnexen