Fix oci_success_with_info.phpt test random failures #9525
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mvorisek, if you change the base (target) branch via GH UI, you also should force-push; otherwise some CI (at least AppVeyor) pick up the wrong branch, usually causing the build to fail. |
mvorisek
force-pushed
the
fix_oracle_test_with_sleep
branch
from
d5b56c0 to
dcf395a
Compare
|
PR is done |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://github.com/php/php-src/runs/8294992596?check_suite_focus=true#step:11:113
I assume the random test failure was cause by evaluating the expire once per second or some time rounding.