Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: sockets constants #9533

Closed
wants to merge 1 commit into from
Closed

Fix: sockets constants #9533

wants to merge 1 commit into from

Conversation

doubaokun
Copy link
Contributor

No description provided.

@doubaokun doubaokun mentioned this pull request Sep 13, 2022
Closed
devnexen
devnexen reviewed Sep 14, 2022
View reviewed changes
ext/sockets/php_sockets.h Outdated Show resolved Hide resolved
devnexen
devnexen approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCTM

@cmb69
Copy link
Member

cmb69 commented Sep 14, 2022

Thank you!

@cmb69 cmb69 closed this in 9f7e27a Sep 14, 2022
@doubaokun doubaokun deleted the fix_sockets_constants branch September 14, 2022 13:30
@kocsismate
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

Assignees
No one assigned
Labels
Extension: sockets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@doubaokun @cmb69 @kocsismate @devnexen