Fix GH-9372: HY010 when binding overlong parameter #9541
Conversation
There was a problem hiding this comment.
LGTM, but I don't have ODBC set up so I haven't actually tested the code but I trust CI.
Maybe just add a comment that "22001" is the expected failure for trying to insert a value which doesn't fit? Took me a second to understand why the expected test output is blank.
Makes sense. Will do. Given the recent discussion regarding BC breaks, I'm no longer convinced that this should target PHP-8.0. After all, some users might actually catch the exception and check only for the |
If `SQLPutData()` *fails*, we should not call `SQLParamData()` again, because that yields the confusing `HY010` (Function sequence error). Instead we properly handle `SQLPutData()` errors. For the given case (paramter length > column length), some drivers let `SQLPutData()` fail, while others do not. Either behavior seems to conform to the ODBC specification. Anyhow, we do not want to silently truncate the given parameter, since that would break the behavior for drivers which do not fail, but still don't simply truncate the given parameter. So it is finally up to userland to avoid passing overlong parameters – with this patch they at least get useful information about the actual issue.
Done.
Also done. |
If
SQLPutData()fails, we should not callSQLParamData()again, because that yields the confusingHY010(Function sequence error). Instead we properly handleSQLPutData()errors.For the given case (paramter length > column length), some drivers let
SQLPutData()fail, while others do not. Either behavior seems to conform to the ODBC specification. Anyhow, we do not want to silently truncate the given parameter, since that would break the behavior for drivers which do not fail, but still don't simply truncate the given parameter. So it is finally up to userland to avoid passing overlong parameters – with this patch they at least get useful information about the actual issue.