Set SA_ONSTACK in zend_sigaction #9597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't this target 8.2? master is currently 8.3-dev |
|
I definitely would like to see it at least for 8.3, @dunglas is doing the right things IMHO nor I have any problem seeing also into the 8.2 branch but should not we ask one of the release managers opinion just to be safe or is it ok ? |
iluuu1994
approved these changes
Sep 26, 2022
|
@saundefined @adoy opinions about landing this in 8.2 or should this be deferred to 8.3? |
|
Unless there is a very strong need to have this change in 8.2 I would recommend to target 8.3 since we already are in an RC phase. |
lstrojny
pushed a commit
to php-amqp/php-amqp
that referenced
this pull request
Jun 4, 2024
Sets SA_ONSTACK and switches from signal to sigaction (see php/php-src#9597)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently working on a new SAPI for web servers written in Go.
Many virtual machines, including Go VM, depend on signals using
SA_ONSTACK. This flag allows a thread to define a new alternate signal stack. Many argue thatSA_ONSTACKshould be a default, but it's not the case (yet).This patch sets the
SA_ONSTACKflag when PHP callssigaction().Python merged a similar patch (python/cpython#24730) in 2021 (Python 3.10+) for the same reasons, with no issues.