Skip to content

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Sep 27, 2022

When a tar phar is created, phar_open_from_fp() is also called, but since the file has just been created, none of the format checks can succeed, so we continue to loop, but must not check again for the format. Therefore, we bring back the old test variable.

When a tar phar is created, `phar_open_from_fp()` is also called, but
since the file has just been created, none of the format checks can
succeed, so we continue to loop, but must not check again for the
format.  Therefore, we bring back the old `test` variable.
@cmb69 cmb69 closed this in 432bf19 Sep 27, 2022
@cmb69 cmb69 deleted the cmb/81726-regression branch September 27, 2022 16:27
patrickallaert pushed a commit that referenced this pull request Sep 28, 2022
When a tar phar is created, `phar_open_from_fp()` is also called, but
since the file has just been created, none of the format checks can
succeed, so we continue to loop, but must not check again for the
format.  Therefore, we bring back the old `test` variable.

Closes GH-9620.
sgolemon pushed a commit that referenced this pull request Sep 28, 2022
When a tar phar is created, `phar_open_from_fp()` is also called, but
since the file has just been created, none of the format checks can
succeed, so we continue to loop, but must not check again for the
format.  Therefore, we bring back the old `test` variable.

Closes GH-9620.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant