Fix potential heap corruption due to alignment mismatch #9724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix for bug 63327[1] changed the extra size of mysqlnd allocations from `sizeof(size_t)` to the properly aligned values; however, the allocation in `_mysqlnd_pestrdup()` has apparently been overlooked, which (currently) causes detectable heap corruption when running mysqli_get_client_stats.phpt on 32bit Windows versions. [1] <php@338a47b>
|
I've just noticed php-src/ext/mysqlnd/mysqlnd_alloc.c Line 25 in 7a6965c Has this perhaps accidentially committed with 37418de? @kamil-tekiela, thoughts? |
|
I don't know. It wasn't an accident as far as I know. This is a user-facing functionality that can be enabled via INI setting |
|
Thanks, @kamil-tekiela! That explains the current behavior, but I agree that this is doubtful, and we should re-consider. |
kamil-tekiela
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix for bug 63327 changed the extra size of mysqlnd allocations from
sizeof(size_t)to the properly aligned values; however, the allocation in_mysqlnd_pestrdup()has apparently been overlooked, which (currently) causes detectable heap corruption when running mysqli_get_client_stats.phpt on 32bit Windows versions.There may be further issues; that should be checked.Apparently, there are no other issues in this regard.