Fix bug #65003 Wrong date diff #973
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timelib_apply_localtime when only zones are different
|
Hi @derickr can check whether this is correct |
|
I'm going to need to sit down when I'm back to my computer to have a look in a few days. Please ping me next week if i forget! |
|
@derickr ping? :) |
|
I don't think it's correct, but haven't had the time yet... This logic is very sensitive, and, I have party tried fixing this in an non-php copy. Just bare with me. |
|
@derickr can we know the status of this issue please ? |
|
Having waited a month for feedback, and since changes to timelib need to land upstream, I'm closing this PR. Please take this action as encouragement to open a PR on the upstream library, and when/if that change lands, to open a new test PR on php-src. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.php.net/bug.php?id=65003
Fixed by only timelib_apply_localtime when zone is different, current date test passes. Hope this is correct.