Skip to content

Restore extra_named_params when restoring frozen call stack #9753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2022
Merged

Restore extra_named_params when restoring frozen call stack #9753

merged 1 commit into from
Oct 16, 2022

Conversation

arnaud-lb
Copy link
Member

Fixes #9752

@arnaud-lb arnaud-lb changed the base branch from master to PHP-8.1 October 14, 2022 17:39
@bwoebi
Copy link
Member

bwoebi commented Oct 14, 2022

Is there a particular reason this is not based on PHP-8.0?

@arnaud-lb arnaud-lb changed the base branch from PHP-8.1 to PHP-8.0 October 15, 2022 09:04
@arnaud-lb
Copy link
Member Author

There is no particular reason actually, thank you for pointing this out. This now targets 8.0

@arnaud-lb arnaud-lb marked this pull request as ready for review October 15, 2022 10:21
nikic
nikic approved these changes Oct 15, 2022
View reviewed changes
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@arnaud-lb arnaud-lb merged commit 86e1fea into php:PHP-8.0 Oct 16, 2022
@arnaud-lb arnaud-lb mentioned this pull request Oct 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generator crashes when interrupted during a function call with extra named params
3 participants
@arnaud-lb @bwoebi @nikic