Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize run time cache in PDO methods #9818

Closed

Conversation

rioderelfte
Copy link
Contributor

Without the memset the memory was uninitialized and the new test segfaulted when accessing the memory in _zend_observe_fcall_begin().

* PHP-8.1:
  Update new test to use EXTENSIONS section instead of SKIPIF
@beberlei
Copy link
Contributor

@bwoebi ping, this failed for the Tideways suite in zend_observer.

Girgias and others added 3 commits October 24, 2022 15:17
The intersection type needs to be marked as being allocated on the arena otherwise zend_persist_type() tries to free it and corrupts the Zend MM Heap

Also we only need to allocate the space for a list of size 1 and not the whole length of the intersection type
* PHP-8.1:
  opcache: fix syntax error introduced in 261a08a (php#9821)
Without the memset the memory was uninitialized and the new test segfaulted when accessing the memory in _zend_observe_fcall_begin().
@rioderelfte
Copy link
Contributor Author

Somehow GitHub got confused. I rebased my commit on top of the current PHP-8.2 branch to fix the build errors. Don't know why GitHub thinks I added all those commits to this PR since they are also in the base branch. Sorry for the confusion 😞

bwoebi pushed a commit that referenced this pull request Oct 26, 2022
Without the memset the memory was uninitialized and the new test segfaulted when accessing the memory in _zend_observe_fcall_begin().
@bwoebi
Copy link
Member

bwoebi commented Oct 26, 2022

Merged via 56c121c.

Thanks for spotting and fixing :-)

@bwoebi bwoebi closed this Oct 26, 2022
@rioderelfte rioderelfte deleted the initialize-run-time-cache branch October 29, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants