Skip to content

Fix octal (finally) #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2015
Merged

Fix octal (finally) #987

merged 1 commit into from
Jan 17, 2015

Conversation

hikari-no-yume
Copy link
Contributor

@laruence
Copy link
Member

laruence commented Jan 9, 2015

nice~

@hikari-no-yume
Copy link
Contributor Author

Unfortunately this breaks a bunch of tests. Which kinda demonstrates why we need to fix this. A lot of them relied on it unintentionally.

@smalyshev smalyshev added the RFC label Jan 10, 2015
@hikari-no-yume hikari-no-yume mentioned this pull request Jan 11, 2015
Closed
@hikari-no-yume hikari-no-yume force-pushed the fix_octal branch 3 times, most recently from 65bf4c9 to 822e27f Compare January 15, 2015 14:28
@hikari-no-yume
Copy link
Contributor Author

Travis is red, but this seems to be unrelated to this patch. It's asort(), my guess is the sorting changes broke it.

@hikari-no-yume hikari-no-yume force-pushed the fix_octal branch 7 times, most recently from 54ca176 to f071da3 Compare January 17, 2015 18:10
@php-pulls php-pulls merged commit 5f29b98 into php:master Jan 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
RFC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hikari-no-yume @laruence @smalyshev @php-pulls