Fix bug #68822 php-fpm - the result of access log is wrong when use fastcgi_finish_request #995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The bug has been around for a while: https://bugs.php.net/bug.php?id=62382 |
|
Tested this with php 5.6.5 on Debian Wheezy and Jessie..bug is fixed: access logs show correct date and request time. |
|
seems correct from me, the related fields are properly initialized in reading header, unnecessary set to zero here... |
|
Merged, thanks! |
|
@tony2001 Awesome..will this make it to 5.6.6/5.5.22 then? |
|
Yep, in all branches starting with 5.5. |
|
Perfect! Thanks @tony2001 |
|
Closing as per @tony2001 's request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the bug is here: https://bugs.php.net/bug.php?id=68822
When I use fastcgi_finish_request in php script, I find the result of access log is wrong
I read the php-src, whe use fastcgi_finish_request, it will call fpm_request_finished(it will clean the value of proc->accepted_epoch && proc->accepted ).
But, fpm_log_write need proc->accepted_epoch && proc->accepted to print the log
The process is like this：
So, I think it is a bug.
By the way,although my PR can solve the problem, but I think it is not very good. -_-||