Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

safe_mode is a dead link #720

Merged
merged 1 commit into from
Nov 15, 2022
Merged

safe_mode is a dead link #720

merged 1 commit into from
Nov 15, 2022

Conversation

sy-records
Copy link
Member

@sy-records sy-records commented Nov 14, 2022 •
edited
Loading

saundefined
saundefined approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@saundefined saundefined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

cmb69
cmb69 approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sy-records
Copy link
Member Author

Hi, @cmb69 @saundefined
Thank you for your review, please merge it.
I don't have merge access. 😅

@Girgias Girgias merged commit 83ca8d7 into php:master Nov 15, 2022
@sy-records sy-records deleted the fix-urlhowto branch November 15, 2022 01:43
@cmb69
Copy link
Member

cmb69 commented Nov 15, 2022

I don't have merge access. 😅

You are supposed to have, though. :)

@sy-records
Copy link
Member Author

sy-records commented Nov 15, 2022 •
edited
Loading

I don't...

Do I need to write an email to apply for access? I'm in doc-team, and there is nothing else.

8A251300-A81B-4F12-A828-B87E21E9D2E2

@cmb69
Copy link
Member

cmb69 commented Nov 15, 2022

I'm in doc-team, and there is nothing else.

Sorry, I thought this was a doc-en PR! I've sent you an invite for the web-team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

@saundefined saundefined saundefined approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sy-records @cmb69 @saundefined @Girgias