Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support serving PHP distribution packages from GitHub releases #758

Closed
wants to merge 3 commits into from

Conversation

ramsey
Copy link
Member

@ramsey ramsey commented Feb 15, 2023

php/php-src#10604 introduces a new automated release workflow for building PHP release packages. With this new workflow, we will no longer serve PHP distributions packages from web-php-distributions, but rather, from GitHub releases. This PR adds support to web-php to create the proper download URLs for the files in GitHub.

Important things to note in this PR:

@ramsey ramsey changed the title Release workflow Support the serving PHP distribution files from GitHub releases Feb 16, 2023
@ramsey ramsey changed the title Support the serving PHP distribution files from GitHub releases Support serving PHP distribution packages from GitHub releases Feb 16, 2023
@ramsey ramsey marked this pull request as ready for review February 16, 2023 00:50
}

if (isset($sig_link)) {
echo " ";
echo make_link($sig_link, "(sig)");
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code below here (and not shown in the diff) checks the file on local disk (i.e., in /distributions/) and calculates the file size to display on the downloads page.

With this new approach, since the files aren't on local disk, none of them will display their sizes, unless we want to make API requests to GitHub to get the file sizes. I chose not to do that in this iteration, since I don't think it's efficient to make those API requests on every page load, and I'm not sure where we would cache that information (if we have a place to cache data).

@carusogabriel
Copy link
Contributor

carusogabriel commented Feb 16, 2023

@ramsey Thanks for proposing this. If you don't mind, give us a few days and we will review it!

@ramsey ramsey closed this Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants